Time entries section #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
suggested changes
Mar 23, 2020
| Field technology is requiered. Enter this field for clock out. | ||
| </div> | ||
| <div *ngIf="showAlertEnterTecnology" class="alert alert-danger" role="alert"> | ||
| Field technology is requiered. Enter this field for clock out. |
| <form> | ||
| <div class="form-group"> | ||
| <input type="text" class="form-control" id="formGroupExampleInput" placeholder=" Search project" | ||
| style="font-family:'Segoe UI', Tahoma, Geneva, Verdana, sans-serif, FontAwesome"> |
There was a problem hiding this comment.
why are we defining all these style inline? should not we create a class?
| </div> | ||
| </div> | ||
| <div class="form-group row"> | ||
| <label for="inputJiraTicket" class="col-sm-2 col-form-label text-center"><strong>Jira Ticket</strong></label> |
There was a problem hiding this comment.
I think all of these styles are just intended to make the screen look exactly the same as time-sheets. We need to make it look better not the same :)
| <h6 class="text-left"><strong>Projects</strong></h6> | ||
| <form> | ||
| <div class="form-group"> | ||
| <input type="text" class="form-control" id="formGroupExampleInput" placeholder=" Search project" |
There was a problem hiding this comment.
This component should be drop-down not a input
enriquezrene
force-pushed
the
time-entries-section
branch
from
b87d6fb to
ed3eaf0
Compare
enriquezrene
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue