Skip to content

Conversation

juanultimate
Copy link
Contributor

Improving the look and feel on the report page so that it can be displayed on medium and low-resolution screens.

@juanultimate juanultimate requested a review from enriquezrene May 30, 2020 18:13
@juanultimate juanultimate force-pushed the improving-report-page-styles branch 4 times, most recently from 265d90c to 4434fe1 Compare May 30, 2020 22:03
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #311 into master will decrease coverage by 3.48%.
The diff coverage is 90.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   94.51%   91.02%   -3.49%     
==========================================
  Files          64       70       +6     
  Lines         984     1092     +108     
  Branches       59       64       +5     
==========================================
+ Hits          930      994      +64     
- Misses         32       75      +43     
- Partials       22       23       +1     
Impacted Files Coverage Δ
...time-entries-table/time-entries-table.component.ts 76.47% <76.47%> (ø)
src/app/modules/time-clock/store/entry.effects.ts 24.52% <80.00%> (ø)
...ared/components/input-date/input-date.component.ts 84.61% <84.61%> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <100.00%> (ø)
...ed/components/input-label/input-label.component.ts 100.00% <100.00%> (ø)
...c/app/modules/time-clock/services/entry.service.ts 100.00% <100.00%> (ø)
src/app/modules/time-clock/store/entry.actions.ts 100.00% <100.00%> (ø)
src/app/modules/time-clock/store/entry.reducer.ts 97.29% <100.00%> (+6.12%) ⬆️
...rc/app/modules/time-clock/store/entry.selectors.ts 100.00% <100.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c65c0...4434fe1. Read the comment docs.

@juanultimate juanultimate force-pushed the improving-report-page-styles branch from 4434fe1 to 2aa8b76 Compare May 31, 2020 04:55
@enriquezrene enriquezrene merged commit a93149b into master May 31, 2020
@enriquezrene enriquezrene deleted the improving-report-page-styles branch May 31, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants