Skip to content

265 remove modal component #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2020
Merged

265 remove modal component #267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2e9ab4
fix: #265 remove modal, fix: 266 adding missing tests
enriquezrene May 19, 2020
4ebb8c7
fix: #266 remove flaky test
enriquezrene May 19, 2020
44deee7
fix: #265 removing dead code
enriquezrene May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: #265 removing dead code
  • Loading branch information
@enriquezrene
enriquezrene committed May 19, 2020
commit 44deee7ffac5cfb2e4807969af1b03030ad93f37
1 change: 0 additions & 1 deletion src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { TimeClockComponent } from './modules/time-clock/pages/time-clock.compon
import { TimeEntriesComponent } from './modules/time-entries/pages/time-entries.component';
import { DetailsFieldsComponent } from './modules/shared/components/details-fields/details-fields.component';
import { ProjectListHoverComponent } from './modules/time-clock/components/project-list-hover/project-list-hover.component';
import { ModalComponent } from './modules/shared/components/modal/modal.component';
import { MonthPickerComponent } from './modules/shared/components/month-picker/month-picker.component';
import { EmptyStateComponent } from './modules/shared/components/empty-state/empty-state.component';
import { GroupByDatePipe } from './modules/shared/pipes/group-by-date/group-by-date.pipe';
Expand Down
1 change: 0 additions & 1 deletion src/app/modules/shared/components/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export * from './clock/clock.component';
export * from './details-fields/details-fields.component';
export * from './empty-state/empty-state.component';
export * from './modal/modal.component';
export * from './month-picker/month-picker.component';
export * from './navbar/navbar.component';
export * from './sidebar/sidebar.component';
Expand Down
2 changes: 0 additions & 2 deletions src/app/modules/time-entries/pages/time-entries.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
MonthPickerComponent,
DetailsFieldsComponent,
EmptyStateComponent,
ModalComponent,
} from '../../shared/components';
import { GroupByDatePipe } from '../../shared/pipes';
import { TechnologyState } from '../../shared/store/technology.reducers';
Expand Down Expand Up @@ -66,7 +65,6 @@ describe('TimeEntriesComponent', () => {
EmptyStateComponent,
DetailsFieldsComponent,
GroupByDatePipe,
ModalComponent,
MonthPickerComponent,
TimeEntriesComponent,
],
Expand Down