Skip to content

Conversation

enriquezrene
Copy link
Contributor

  • This PR removes the autocomplete component in time-clock by an HTML select component
  • Fix the flaky test on clock-in which was failing
  • Remove the error when modal is tried to be closed before it exists

…ock-in, fix an issue when element is null
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #262 into master will increase coverage by 0.08%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   93.55%   93.64%   +0.08%     
==========================================
  Files          63       63              
  Lines         978      960      -18     
  Branches       61       57       -4     
==========================================
- Hits          915      899      -16     
+ Misses         44       42       -2     
  Partials       19       19              
Impacted Files Coverage Δ
.../components/entry-fields/entry-fields.component.ts 86.95% <ø> (ø)
...ponents/details-fields/details-fields.component.ts 91.07% <66.66%> (-4.65%) ⬇️
...project-list-hover/project-list-hover.component.ts 95.23% <100.00%> (+15.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0463a02...f5ea0e5. Read the comment docs.

@enriquezrene enriquezrene merged commit 97780bd into master May 19, 2020
@enriquezrene enriquezrene deleted the 260-replace-autocomplete-by-select branch May 19, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant