Skip to content

Conversation

enriquezrene
Copy link
Contributor

  • Moving some messages to effects
  • Removing message each time an entry is updated
  • Creating a shared class to hold messages to be used by the toastrService

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #245 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   92.73%   92.71%   -0.02%     
==========================================
  Files          63       63              
  Lines        1018     1016       -2     
  Branches       64       64              
==========================================
- Hits          944      942       -2     
  Misses         51       51              
  Partials       23       23              
Impacted Files Coverage Δ
...p/modules/time-clock/pages/time-clock.component.ts 81.81% <100.00%> (-2.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1327db7...a637d55. Read the comment docs.

@enriquezrene enriquezrene merged commit 5491201 into master May 15, 2020
@enriquezrene enriquezrene deleted the 242-remove-message-on-entry-updated branch May 15, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant