222/feature create technologies component #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanultimate
force-pushed
the
222/feature-create-technologies-component
branch
from
de91365 to
238fb8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 91.81% 91.90% +0.09%
==========================================
Files 60 61 +1
Lines 953 964 +11
Branches 61 61
==========================================
+ Hits 875 886 +11
+ Misses 57 55 -2
- Partials 21 23 +2
Continue to review full report at Codecov.
|
juanultimate
force-pushed
the
222/feature-create-technologies-component
branch
from
238fb8f to
1639d0d
Compare
juanultimate
force-pushed
the
222/feature-create-technologies-component
branch
from
1639d0d to
c4fbfff
Compare
juanultimate
force-pushed
the
222/feature-create-technologies-component
branch
from
c4fbfff to
424ad5f
Compare
enriquezrene
suggested changes
May 13, 2020
| }); | ||
| } | ||
|
|
||
| addTechnology(name: string) { |
There was a problem hiding this comment.
We don't want to display already selected technologies in the component @juanultimate. Only not selected technologies should be displayed in the component.
enriquezrene
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It extracts the technologies dropdown as a component.