fix: #154 Filter projects and project types by customer #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 91.80% 92.90% +1.09%
==========================================
Files 59 60 +1
Lines 830 860 +30
Branches 50 52 +2
==========================================
+ Hits 762 799 +37
+ Misses 46 38 -8
- Partials 22 23 +1
Continue to review full report at Codecov.
|
| @@ -28,12 +30,15 @@ export class CreateProjectTypeComponent implements OnInit { | |||
| this.projectTypeToEdit = projectType; | |||
| this.setDataToUpdate(this.projectTypeToEdit); | |||
| }); | |||
| const getCustomerId$ = this.store.pipe(select(getCustomerId)); | |||
| getCustomerId$.subscribe((customerId) => { | |||
There was a problem hiding this comment.
please add a variable for subscription a remove it with a ngDestroy()
| @@ -44,6 +46,10 @@ export class CreateProjectComponent implements OnInit, OnDestroy { | |||
| this.projectTypesSubscription = projectsTypes$.subscribe((projectsType) => { | |||
| this.projectsTypes = projectsType; | |||
| }); | |||
| const getCustomerId$ = this.store.pipe(select(getCustomerId)); | |||
| getCustomerId$.subscribe((customerId) => { | |||
There was a problem hiding this comment.
add a variable for subscription an remove it in ngDestroy
DiegoTinitana
force-pushed
the
154_Filter_projects_and_project_types_by_customer
branch
from
fa8ebf2 to
9db1baf
Compare
enriquezrene
approved these changes
Apr 30, 2020
enriquezrene
deleted the
154_Filter_projects_and_project_types_by_customer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.