fix: #147 Display correct username fix test #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 91.94% 91.97% +0.02%
==========================================
Files 57 57
Lines 708 785 +77
Branches 40 45 +5
==========================================
+ Hits 651 722 +71
- Misses 45 46 +1
- Partials 12 17 +5
Continue to review full report at Codecov.
|
enriquezrene
approved these changes
Apr 23, 2020
macrisguncay
approved these changes
Apr 23, 2020
| let activityIdtoEditMock; | ||
| let allActivitiesMock; | ||
| let getActivityByIdMock; | ||
| let getActivityByIdSelectorMock; |
There was a problem hiding this comment.
yo can use the variable getActivityByIdMock that is to mock that selector, you don't need to create getActivityByIdSelectorMock
| let projectTypeIdToEditMock; | ||
| let allProjectTypesMock; | ||
| let getProjectTypeByIdMock; | ||
| let getProjectTypeByIdSelectorMock; |
There was a problem hiding this comment.
tha same case. you can use getProjectTypeByIdMock and not create a new variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.