fix: #91 manage-projects #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
suggested changes
Apr 22, 2020
| @@ -21,12 +22,16 @@ export class ProjectService { | |||
| return this.http.post<Project[]>(this.url, { | |||
| ...projectData, | |||
| customer_id: 'b6e6a2f1-ce5c-49b3-8649-d154b4f3c305', | |||
| tenant_id: 'b95385bd-d0f4-4823-b874-af9421c14c8e', | |||
| tenant_id: this.azureAdB2CService.getTenantId(), | |||
There was a problem hiding this comment.
we no longer need a tenant_id, this value is going to be read from the JWT so feel free to remove it 😃
| (project_type_id.dirty || project_type_id.touched) && project_type_id.invalid && project_type_id.errors.required | ||
| " | ||
| > | ||
| Project type is required. |
There was a problem hiding this comment.
Actually, the type is not required. Let's remove this validation.
macrisguncay
force-pushed
the
91-manage-projects
branch
from
fae34f6 to
891490a
Compare
enriquezrene
approved these changes
Apr 22, 2020
macrisguncay
force-pushed
the
91-manage-projects
branch
from
891490a to
d683ce2
Compare
enriquezrene
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the ticket: #91