89 edit and delete customres #157
Conversation
daros10
force-pushed
the
89-Edit-and-delete-customers
branch
from
0a5ff9a to
4e1bc8f
Compare
| import { CustomerState, CreateCustomer } from 'src/app/modules/customer-management/store'; | ||
| import * as models from 'src/app/modules/shared/models/index'; | ||
| import { LoadCustomers } from './../../../../store/customer-management.actions'; | ||
| import * as models from 'src/app/modules/shared/models/index'; |
There was a problem hiding this comment.
import should be
import { Customer } from 'src/app/modules/shared/models';
| import { CustomerState, CreateCustomer, LoadCustomers } from 'src/app/modules/customer-management/store'; | ||
| import { getStatusMessage } from './../../../../store/customer-management.selectors'; | ||
| import { getStatusMessage, getCustomerById } from './../../../../store/customer-management.selectors'; | ||
| import { Customer } from 'src/app/modules/shared/models/index'; |
There was a problem hiding this comment.
import should be
import { Customer } from 'src/app/modules/shared/models';
| if (this.customerToEdit) { | ||
| const customer = { | ||
| ...customerData, | ||
| id: this.customerToEdit[key], |
There was a problem hiding this comment.
I think a better solution would be this.
const customer = { ...this.customerToEdit, ...customerData }; o const customer = { ...customerData, id: this.customerToEdit.id };
with this we would eliminate line 57
const key = 'id';
| action: CustomerManagementActions | ||
| ): CustomerState { | ||
| const customersList = [...state.data]; | ||
| const key = 'id'; |
There was a problem hiding this comment.
Please, let's apply the previous comment here too
| customerIdToEdit: '', | ||
| }; | ||
|
|
||
| export function customerManagementReducer( |
There was a problem hiding this comment.
we must use arrow functions
| export const getCustomerById = createSelector(allCustomers, customerIdtoEdit, (customers, customerId) => { | ||
| const key = 'id'; | ||
| return customers.find((customer) => { | ||
| return customer[key] === customerId; |
There was a problem hiding this comment.
I think you should add an "id" in the Customer interface to avoid this.
src/app/modules/customer-management/store/customer-management.actions.ts
Show resolved
Hide resolved
src/app/modules/customer-management/store/customer-management.reducers.ts
Show resolved
Hide resolved
| const url = `${this.baseUrl}/${customerData.id}`; | ||
| const body = { | ||
| ...customerData, | ||
| }; |
There was a problem hiding this comment.
body object it's not necessary, please remove it and send directly customerData.
Please remove it also remove in createCustomer method, and remove the tenantId.
| }); | ||
|
|
||
| export const getCustomerById = createSelector(allCustomers, customerIdtoEdit, (customers, customerId) => { | ||
| return customers.find((customer) => { |
There was a problem hiding this comment.
could add the validation for (customers, customerId)
There was a problem hiding this comment.
All changes were applied. @enriquezrene when you have a free time, please, check it.
Issue realted to #89.