87 save customers #139

daros10 · 2020-04-17T19:13:38Z

Issue #87.

…ker-ui into 87-Save-customers

codecov · 2020-04-17T19:16:35Z

Codecov Report

Merging #139 into master will decrease coverage by 0.24%.
The diff coverage is 90.38%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   92.42%   92.18%   -0.25%     
==========================================
  Files          47       50       +3     
  Lines         449      499      +50     
  Branches       27       32       +5     
==========================================
+ Hits          415      460      +45     
- Misses         26       29       +3     
- Partials        8       10       +2

Impacted Files	Coverage Δ
...omponents/customer-list/customer-list.component.ts	`100.00% <ø> (ø)`
...eate-project-type/create-project-type.component.ts	`100.00% <ø> (ø)`
...s/project-type-list/project-type-list.component.ts	`100.00% <ø> (ø)`
...ponents/create-project/create-project.component.ts	`100.00% <ø> (ø)`
.../components/project-list/project-list.component.ts	`100.00% <ø> (ø)`
...es/customer-management/pages/customer.component.ts	`100.00% <ø> (ø)`
...-management/store/customer-management.selectors.ts	`50.00% <50.00%> (ø)`
...r-management/store/customer-management.reducers.ts	`62.50% <62.50%> (ø)`
...info/components/create-customer/create-customer.ts	`100.00% <100.00%> (ø)`
...projects/management-customer-projects.component.ts	`100.00% <100.00%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9d621...b2a4427. Read the comment docs.

jorgecod · 2020-04-17T19:25:01Z

...s/customer-management/components/customer-info/components/create-customer/create-customer.ts

+    const messages$ = this.store.pipe(select(getStatusMessage));
+    this.saveSubscription = messages$.subscribe((valueMessage) => {
+      this.setStatusOnScreen(valueMessage);
+      console.log(valueMessage);


Please, delete this console.log

jorgecod · 2020-04-17T19:27:33Z

src/app/modules/customer-management/services/customer.service.ts

+  createCustomer(customerData): Observable<any> {
+    const body = {
+      ...customerData,
+      tenant_id: '4225ab1e-1033-4a5f-8650-0dd4950f38c8',


@enriquezrene Do we still need to set a tenant_id fake?

I think @daros10 needs to talk to @macrisguncay to understand how to get the tenant_id from the session_storage. Good catch @jorgecod, ty.

changes was applied except this.

@daros10 you can get the real tenant id and bearer token from session storage, I implemented these methods in AzureAdB2CService, please check it and use them please.

thank you @macrisguncay , @enriquezrene all review requesting was applied.

jorgecod · 2020-04-17T19:31:25Z

...s/customer-management/components/customer-info/components/create-customer/create-customer.ts

+import { Component, Input, Output, EventEmitter, OnDestroy, OnInit } from '@angular/core';
+import { Store, select } from '@ngrx/store';
+import { CustomerState, CreateCustomer } from 'src/app/modules/customer-management/store';
+import { FormGroup, FormBuilder, Validators } from '@angular/forms';


Please sort imports by module.

jorgecod · 2020-04-17T19:32:36Z

src/app/modules/customer-management/services/customer.service.spec.ts

+import { TestBed, inject } from '@angular/core/testing';
+
+import { CustomerService } from './customer.service';
+import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';


Please sort imports by module

jorgecod · 2020-04-17T19:35:17Z

...tomer-management/components/customer-info/components/create-customer/create-customer.spec.ts

+import { MockStore, provideMockStore } from '@ngrx/store/testing';
+import { CustomerState, CreateCustomer } from 'src/app/modules/customer-management/store';
+import { FormBuilder } from '@angular/forms';
+import { Customer } from 'src/app/modules/shared/models/customer.model';


The customer.model must be added in the index file in 'src/app/modules/shared/models/index.ts'

jorgecod · 2020-04-17T19:36:38Z

...tomer-management/components/customer-info/components/create-customer/create-customer.spec.ts

+import { CreateCustomerComponent } from './create-customer';
+import { MockStore, provideMockStore } from '@ngrx/store/testing';
+import { CustomerState, CreateCustomer } from 'src/app/modules/customer-management/store';
+import { FormBuilder } from '@angular/forms';


Please sort imports by module

enriquezrene · 2020-04-17T19:37:01Z

...customer-management/components/customer-info/components/create-customer/create-customer.html

+    <div class="form-group">
+      <div
+        *ngIf="showAlert && messageToShow !== ''"
+        [ngClass]="{'bg-secondary': messageToShow == 'Customer create successfully!', 'bg-primary': messageToShow != 'Customer create successfully!'}"


typo:
Customer created successfully!

enriquezrene · 2020-04-17T19:38:30Z

...tomer-management/components/customer-info/components/create-customer/create-customer.spec.ts

+
+    component.setStatusOnScreen('Customer create successfully!');
+
+    expect(component.messageToShow).toEqual('Customer create successfully!');


Customer created successfully

enriquezrene · 2020-04-17T19:39:25Z

...tomer-management/components/customer-info/components/create-customer/create-customer.spec.ts

+    expect(component.isActiveItemTabs).toBeTrue();
+  });
+
+  it('should be disabled tabs and show message Something went wrong creating customer! ', () => {


it('should disable tabs and show a message "An error occurred, try again later." '

enriquezrene · 2020-04-17T19:40:09Z

...s/customer-management/components/customer-info/components/create-customer/create-customer.ts

+})
+export class CreateCustomerComponent implements OnInit, OnDestroy {
+  customerForm: FormGroup;
+  @Input() isActiveItemTabs: boolean;


A better name would be:
areTabsActive

enriquezrene · 2020-04-17T19:43:00Z

src/app/modules/customer-management/services/customer.service.ts

+  createCustomer(customerData): Observable<any> {
+    const body = {
+      ...customerData,
+      tenant_id: '4225ab1e-1033-4a5f-8650-0dd4950f38c8',


I think @daros10 needs to talk to @macrisguncay to understand how to get the tenant_id from the session_storage. Good catch @jorgecod, ty.

… 87-Save-customers

macrisguncay · 2020-04-17T22:55:45Z

src/app/modules/customer-management/services/customer.service.ts

+      ...customerData,
+      tenant_id: this.service.getTenantId(),
+    };
+    console.log(this.service.getTenantId());


remove the console.log please.

daros10 added 5 commits April 16, 2020 19:07

fix: #87 c1-save-customers

016d0c6

fix: #87 c2-save-customers-tests

d038c10

fix: #87 c3-save-customers

4863d19

fix: #87 c1-save-customers

f2f62e4

Merge branch '87-Save-customers' of https://github.com/ioet/time-trac…

2cc4c8c

…ker-ui into 87-Save-customers

jorgecod reviewed Apr 17, 2020

View reviewed changes

enriquezrene suggested changes Apr 17, 2020

View reviewed changes

daros10 added 4 commits April 17, 2020 16:26

fix: #87 fixed issues and remove search component

2e9aef9

Merge branch 'master' of https://github.com/ioet/time-tracker-ui into…

b760c32

… 87-Save-customers

fix: #87 get tenant_id from session storage

925becb

fix: #87 get tenant_id from AzureServices

d4ff348

macrisguncay reviewed Apr 17, 2020

View reviewed changes

remove console log

b2a4427

enriquezrene approved these changes Apr 17, 2020

View reviewed changes

enriquezrene closed this Apr 17, 2020

enriquezrene reopened this Apr 17, 2020

enriquezrene merged commit a6f248b into master Apr 17, 2020

enriquezrene deleted the 87-Save-customers branch April 17, 2020 23:06


		component.setStatusOnScreen('Customer create successfully!');

		expect(component.messageToShow).toEqual('Customer create successfully!');

87 save customers #139

87 save customers #139

Uh oh!

Conversation

daros10 commented Apr 17, 2020

Uh oh!

codecov bot commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daros10 Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Apr 17, 2020 •

edited

Loading

daros10 Apr 17, 2020 •

edited

Loading