fix: TT-24 rename some variables

Author: lenshinoda

src/app/modules/customer-management/components/projects/components/project-list/project-list.component.html

@@ -13,7 +13,7 @@
       <tr class="d-flex" *ngFor="let project of projects">
         <td class="col-sm-4">{{ project.id }}</td>
         <td class="col-sm-3">{{ project.name }}</td>
-        <td class="col-sm-3">{{ getProjectType(project.project_type_id) }}</td>
+        <td class="col-sm-3">{{ getProjectTypeName(project.project_type_id) }}</td>
         <td class="col-sm-1 text-center">
           <button type="button" class="btn btn-sm btn-primary" (click)="updateProject(project)">
             <i class="fa fa-pencil fa-xs"></i>

src/app/modules/customer-management/components/projects/components/project-list/project-list.component.spec.ts

@@ -156,25 +156,28 @@ describe('ProjectListComponent', () => {
   });
 
   it('getProjectType should be called to display it in projects table', () => {
-    const nameType = {
+    const projectType = {
       id: '1234',
       name: 'BK',
       description: 'test',
     };
     const id = '1234';
-    component.projectsTypes = [nameType];
+
+    component.projectsTypes = [projectType];
     component.ngOnInit();
-    const nameTest = component.getProjectType(id);
-    expect(nameTest).toBe('BK');
+
+    const projectNameTest = component.getProjectTypeName(id);
+    expect(projectNameTest).toBe('BK');
   });
 
   it('projects table should display Project Type', (done) => {
-    const nameType = {
+    const projectType = {
       id: '1234',
       name: 'BK',
       description: 'test',
     };
-    component.projectsTypes = [nameType];
+
+    component.projectsTypes = [projectType];
     fixture.detectChanges();
     fixture.whenStable().then(() => {
       fixture.detectChanges();

src/app/modules/customer-management/components/projects/components/project-list/project-list.component.ts

@@ -75,11 +75,11 @@ export class ProjectListComponent implements OnInit, OnDestroy {
     }
   }
 
-  getProjectType(typeId: string) {
-    const typeName = this.projectsTypes.find(
+  getProjectTypeName(typeId: string) {
+    const typeProject = this.projectsTypes.find(
       (prop) => prop.id === typeId
     );
-    return typeName !== undefined ? typeName.name : '';
+    return typeProject !== undefined ? typeProject.name : '';
   }
 
   updateProject(project) {