fix: TT-24 Solving code smell problem and some fail test

lenshinoda · lenshinoda · commit fcf718fb3f6c · 2021-05-14T10:47:00.000-05:00
diff --git a/src/app/modules/customer-management/components/projects/components/project-list/project-list.component.spec.ts b/src/app/modules/customer-management/components/projects/components/project-list/project-list.component.spec.ts
@@ -174,7 +174,6 @@ describe('ProjectListComponent', () => {
       name: 'BK',
       description: 'test',
     };
-    const id = '1234';
     component.projectsTypes = [nameType];
     fixture.detectChanges();
     fixture.whenStable().then(() => {
diff --git a/src/app/modules/customer-management/components/projects/components/project-list/project-list.component.ts b/src/app/modules/customer-management/components/projects/components/project-list/project-list.component.ts
@@ -70,7 +70,9 @@ export class ProjectListComponent implements OnInit, OnDestroy {
 
   ngOnDestroy() {
     this.projectsSubscription.unsubscribe();
-    this.projectTypesSubscription.unsubscribe();
+    if (this.projectTypesSubscription){
+      this.projectTypesSubscription.unsubscribe();
+    }
   }
 
   getProjectType(typeId: string) {

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,9 @@ export class ProjectListComponent implements OnInit, OnDestroy {`
`70`	`70`
`71`	`71`	`ngOnDestroy() {`
`72`	`72`	`this.projectsSubscription.unsubscribe();`
`73`		`- this.projectTypesSubscription.unsubscribe();`
	`73`	`+ if (this.projectTypesSubscription){`
	`74`	`+ this.projectTypesSubscription.unsubscribe();`
	`75`	`+ }`
`74`	`76`	`}`
`75`	`77`
`76`	`78`	`getProjectType(typeId: string) {`