Skip to content

Commit 17026d3

Browse files
committed
#78 PR comments
1 parent a7f3b53 commit 17026d3

File tree

16 files changed

+23
-45
lines changed

16 files changed

+23
-45
lines changed

src/app/app-routing.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const routes: Routes = [
2020
{ path: 'time-clock', component: TimeClockComponent },
2121
{ path: 'time-entries', component: TimeEntriesComponent },
2222
{ path: 'activities-management', component: ActivitiesManagementComponent },
23-
{ path: 'customer-managment', component: CustomerComponent },
23+
{ path: 'customers-management', component: CustomerComponent },
2424
{ path: '', pathMatch: 'full', redirectTo: 'time-clock' },
2525
],
2626
},

src/app/modules/customer-managment/components/customer-info/components/create-customer/create-customer.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('InputCustomerComponent', () => {
1818
fixture.detectChanges();
1919
});
2020

21-
it('component should create', () => {
21+
it('component should be created', () => {
2222
expect(component).toBeTruthy();
2323
});
2424
});

src/app/modules/customer-managment/components/customer-info/components/customer-list/customer-list.component.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@
1212
>
1313
<td class="col-sm-9">{{ customer.name }}</td>
1414
<td class="col-sm-3 text-center">
15-
<button (click)="activateCustomerForm()" type="button" class="btn btn-sm btn-secondary">
15+
<button type="button" class="btn btn-sm btn-secondary">
1616
<i class="fa fa-pencil fa-xs"></i>
1717
</button>
18-
<button type="button" class="btn btn-sm btn-danger ml-2"><i class="fas fa-trash-alt fa-xs"></i></button>
18+
<button type="button" class="btn btn-sm btn-danger ml-2">
19+
<i class="fas fa-trash-alt fa-xs"></i>
20+
</button>
1921
</td>
2022
</tr>
2123
</tbody>

src/app/modules/customer-managment/components/customer-info/components/customer-list/customer-list.component.spec.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,8 @@ describe('CustomerTableListComponent', () => {
2020
fixture.detectChanges();
2121
});
2222

23-
it('component should create', () => {
23+
it('component should be created', () => {
2424
expect(component).toBeTruthy();
2525
});
2626

27-
it('changeShowCustomerForm should listen form changes', () => {
28-
component.showCustomerForm = true;
29-
spyOn(component.changeShowCustomerForm, 'emit');
30-
component.activateCustomerForm();
31-
expect(component.changeShowCustomerForm.emit).toHaveBeenCalled();
32-
});
3327
});

src/app/modules/customer-managment/components/customer-info/components/customer-list/customer-list.component.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, Input, Output, EventEmitter } from '@angular/core';
1+
import { Component } from '@angular/core';
22
import { ITEMS_PER_PAGE } from 'src/environments/environment';
33

44
@Component({
@@ -29,13 +29,6 @@ export class CustomerListComponent {
2929
},
3030
];
3131

32-
@Input() showCustomerForm;
33-
@Output() changeShowCustomerForm = new EventEmitter<boolean>();
34-
3532
constructor() {}
3633

37-
activateCustomerForm() {
38-
this.showCustomerForm = true;
39-
this.changeShowCustomerForm.emit(this.showCustomerForm);
40-
}
4134
}

src/app/modules/customer-managment/components/projects-type/components/create-project-type/create-project-type.component.html

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,9 @@
22
<form style="width: 600px;">
33
<div class="form-group">
44
<input type="text" class="form-control form-control-sm" id="" aria-describedby="" placeholder="Name" />
5-
<textarea
6-
class="form-control form-control-sm mt-2"
7-
id="descriptionTextArea"
8-
rows="3"
9-
placeholder="Description"
10-
></textarea>
11-
<button type="submit" class="btn btn-sm btn-primary mb-2 mt-2">Save</button>
5+
<textarea class="form-control form-control-sm mt-2" id="descriptionTextArea" rows="3"
6+
placeholder="Description"></textarea>
7+
<button type="submit" class="btn btn-sm btn-primary">Save</button>
128
<button type="submit" class="btn btn-sm btn-secondary mb-2 ml-2 mt-2">Cancel</button>
139
</div>
1410
</form>

src/app/modules/customer-managment/components/projects-type/components/create-project-type/create-project-type.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('InputProjectTypeComponent', () => {
1818
fixture.detectChanges();
1919
});
2020

21-
it('component should create', () => {
21+
it('component should be created', () => {
2222
expect(component).toBeTruthy();
2323
});
2424
});

src/app/modules/customer-managment/components/projects-type/components/project-type-list/project-type-list.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe('ProjectTypeTableListComponent', () => {
2020
fixture.detectChanges();
2121
});
2222

23-
it('component should create', () => {
23+
it('component should be created', () => {
2424
expect(component).toBeTruthy();
2525
});
2626
});

src/app/modules/customer-managment/components/projects/components/create-project/create-project.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('InputProjectComponent', () => {
1818
fixture.detectChanges();
1919
});
2020

21-
it('component should create', () => {
21+
it('component should be created', () => {
2222
expect(component).toBeTruthy();
2323
});
2424
});

src/app/modules/customer-managment/components/projects/components/project-list/project-list.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe('ProjectTableListComponent', () => {
2020
fixture.detectChanges();
2121
});
2222

23-
it('component should create', () => {
23+
it('component should be created', () => {
2424
expect(component).toBeTruthy();
2525
});
2626
});

0 commit comments

Comments
 (0)