refactor: TT-106 New tests for the ProjectListHover component to verify the behavior of ngOnDestroy when the flag is true or false

Author: VanessaIniguezG

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.spec.ts

@@ -58,7 +58,7 @@ describe('ProjectListHoverComponent', () => {
     fixture = TestBed.createComponent(ProjectListHoverComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();
-    // featureManagerService = TestBed.inject(FeatureManagerService);
+    featureManagerService = TestBed.inject(FeatureManagerService);
   });
 
   it('should create', () => {
@@ -143,6 +143,36 @@ describe('ProjectListHoverComponent', () => {
     expect(component.projectsForm.setValue)
       .toHaveBeenCalledWith({ project_id: 'customer - xyz'});
   });
+ 
+    var toggleValue = true;
+    fit(`when FeatureToggle is ${toggleValue} should return ${toggleValue}`, () => {
+      spyOn(featureManagerService, 'isToggleEnabledForUser').and.returnValue(of(toggleValue));
+      component.projectsSubscription = new Subscription();
+      component.activeEntrySubscription = new Subscription();
+
+      spyOn(component.projectsSubscription, 'unsubscribe');
+      spyOn(component.activeEntrySubscription, 'unsubscribe');
+
+      component.ngOnDestroy();
+
+      expect(component.projectsSubscription.unsubscribe).toHaveBeenCalled();
+      expect(component.activeEntrySubscription.unsubscribe).toHaveBeenCalled();
+    });
+
+    toggleValue = false;
+    fit(`when FeatureToggle is ${toggleValue} should return ${toggleValue}`, () => {
+      spyOn(component, 'isFeatureToggleActivated').and.returnValue(of(toggleValue));
+      component.projectsSubscription = new Subscription();
+      component.activeEntrySubscription = new Subscription();
+
+      spyOn(component.projectsSubscription, 'unsubscribe');
+      spyOn(component.activeEntrySubscription, 'unsubscribe');
+
+      component.ngOnDestroy();
+
+      expect(component.projectsSubscription.unsubscribe).not.toHaveBeenCalled();
+      expect(component.activeEntrySubscription.unsubscribe).not.toHaveBeenCalled();
+    });
 
   // const exponentialGrowth = [true, false];
   // exponentialGrowth.map((toggleValue) => {
@@ -187,4 +217,5 @@ describe('ProjectListHoverComponent', () => {
   //     })
   //   );
   // });
+  
 });

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts

@@ -109,7 +109,7 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
     }
   }
 
-   ngOnDestroy(): void {
+  ngOnDestroy(): void {
     if(this.isFeatureToggleActivated()){
       this.projectsSubscription.unsubscribe();
       this.activeEntrySubscription.unsubscribe();
@@ -119,6 +119,6 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
 
   isFeatureToggleActivated() {
     return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
-      map((enabled) => enabled));
+      map((enabled) => enabled === true ? true : false));
   }
 }