refactor: TT-106 Delete exponentialGrowth variable in the TimeClock, ProjectListHover and EntryFields components

Author: VanessaIniguezG

src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts

@@ -36,7 +36,6 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
   loadActivitiesSubscription: Subscription;
   loadActiveEntrySubscription: Subscription;
   actionSetDateSubscription: Subscription;
-  exponentialGrowth;
 
   constructor(
     private featureManagerService: FeatureManagerService,
@@ -177,9 +176,8 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
   }
 
 
-  async ngOnDestroy():Promise<void>  {
-    this.exponentialGrowth = await this.isFeatureToggleActivated();
-    if (this.exponentialGrowth) {
+   ngOnDestroy(): void  {
+    if (this.isFeatureToggleActivated()) {
       this.loadActivitiesSubscription.unsubscribe();
       this.loadActiveEntrySubscription.unsubscribe();
       this.actionSetDateSubscription.unsubscribe();
@@ -188,9 +186,6 @@ export class EntryFieldsComponent implements OnInit, OnDestroy {
 
   isFeatureToggleActivated() {
     return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
-      map((enabled) => {
-          return enabled === true ? true : false;
-      })
-    ).toPromise();
+      map((enabled) => enabled));
   }
 }

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts

@@ -27,7 +27,6 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
   isLoading$: Observable<boolean>;
   projectsSubscription: Subscription;
   activeEntrySubscription: Subscription;
-  exponentialGrowth;
 
   constructor(private featureManagerService: FeatureManagerService,
               private formBuilder: FormBuilder, private store: Store<ProjectState>,
@@ -110,9 +109,8 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
     }
   }
 
-  async ngOnDestroy(): Promise<void> {
-    this.exponentialGrowth = await this.isFeatureToggleActivated();
-    if(this.exponentialGrowth){
+   ngOnDestroy(): void {
+    if(this.isFeatureToggleActivated()){
       this.projectsSubscription.unsubscribe();
       this.activeEntrySubscription.unsubscribe();
     }
@@ -121,9 +119,6 @@ export class ProjectListHoverComponent implements OnInit, OnDestroy {
 
   isFeatureToggleActivated() {
     return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
-      map((enabled) => {
-         return enabled === true ? true : false;
-      })
-    ).toPromise();
+      map((enabled) => enabled));
   }
 }

src/app/modules/time-clock/pages/time-clock.component.ts

@@ -24,7 +24,6 @@ export class TimeClockComponent implements OnInit, OnDestroy {
   activeTimeEntry: Entry;
   clockOutSubscription: Subscription;
   storeSubscription: Subscription;
-  exponentialGrowth;
 
   constructor(
     private featureManagerService: FeatureManagerService,
@@ -73,19 +72,15 @@ export class TimeClockComponent implements OnInit, OnDestroy {
     }
   }
 
- async ngOnDestroy(): Promise<void> {
-  this.exponentialGrowth = await this.isFeatureToggleActivated();
-  this.exponentialGrowth && this.storeSubscription.unsubscribe();
+ ngOnDestroy(): void {
+  this.isFeatureToggleActivated() && this.storeSubscription.unsubscribe();
   this.clockOutSubscription.unsubscribe();
   this.storeSubscription.unsubscribe();
 }
 
   isFeatureToggleActivated() {
     return this.featureManagerService.isToggleEnabledForUser('exponential-growth').pipe(
-      map((enabled) => {
-        return enabled === true ? true : false;
-      })
-    ).toPromise();
+      map((enabled) => enabled));
   }
 }