Solve #46 by using standard naming of env vars #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliuX
force-pushed
the
feature/solve-issues-with-azure-env-vars#46
branch
5 times, most recently
from
2ac87ba to
5ca9566
Compare
EliuX
force-pushed
the
feature/solve-issues-with-azure-env-vars#46
branch
from
5ca9566 to
160cf18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the user of env variables in Azure. In addition, having into account that all variables we set are gotten in Python as strings, e.g.
Truewe need to set a convention to what is a Truthy or a falsy value. So I decided to basically allow to specify some falsy discrete values, which are:false0disabledAny different string to those ones (case-insensitive) will be considered as True. These values will be contained in the constant
time_tracker_api.config.DISABLE_STR_VALUES.