Implementation and test of api namespaces for time entries #13 #43
Conversation
EliuX
changed the title
time_tracker_api/api.py
Outdated
| from flask_restplus import Api, fields | ||
| from flask_restplus._http import HTTPStatus | ||
| from flask_restplus.fields import Raw, to_marshallable_type, MarshallingError | ||
| from werkzeug.exceptions import Conflict |
There was a problem hiding this comment.
I don't see how the two last imports are being used.
There was a problem hiding this comment.
Sure, I will remove them
time_tracker_api/sql_repository.py
Outdated
| return self | ||
|
|
||
| SQLModel = SQLModelClass | ||
| SQLModel = DatabaseModel |
There was a problem hiding this comment.
Checking at changes of DatabaseModel Class, and tracing use of SQLModel It seems to me that these two classes are not useful anymore.
There was a problem hiding this comment.
Whatever particularity that has to be inherited by the SQLModels should be done throw the SQL model. The DatabaseModel is platform-agnostic. Before we had this to_dto function that was required by such models. This is basically an encapsulation.
time_tracker_api/database.py
Outdated
| self.run() # pragma: no cover | ||
|
|
||
|
|
||
| class DatabaseModel: |
There was a problem hiding this comment.
As I said in another comment. https://github.com/ioet/time-tracker-api/pull/43/files#r398215021 I think this class is not needed anymore.
There was a problem hiding this comment.
Ok, I will remove then ;)
EliuX
force-pushed
the
feature/Persist-api-ns-for-time-entries#13
branch
from
6a9c18e to
b4d11ac
Compare
This PR: