Skip to content

TT-613 HOTFIX: Overflow due to Users Pagination #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged

TT-613 HOTFIX: Overflow due to Users Pagination #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
hotfix: created a variable that contains the original endpoint
  • Loading branch information
@codigodehoy
codigodehoy committed Apr 12, 2022
commit 09392f5fc197f529a298bb02ff711ca51c4f73c9
9 changes: 5 additions & 4 deletions utils/azure_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,16 @@ def users(self) -> List[AzureUser]:
role_fields_params=role_fields_params,
)

final_endpoint = endpoint
exists_users = True
users = []
valid_users = []
skip_token_attribute = '&$skiptoken='

while exists_users:
response = requests.get(
endpoint, auth=BearerAuth(self.access_token)
)
final_endpoint, auth=BearerAuth(self.access_token)
)
json_response = response.json()
assert 200 == response.status_code
assert 'value' in json_response
Expand All @@ -131,8 +132,8 @@ def users(self) -> List[AzureUser]:
request_token = remaining_users_link.split(
skip_token_attribute
)[1]
endpoint = endpoint + skip_token_attribute + request_token
final_endpoint = endpoint + skip_token_attribute + request_token

for user in users:
user_emails = user['otherMails']
if(len(user_emails) != 0 and user_emails[0].split('@')[1] == 'ioet.com'):
Expand Down