Skip to content

Hot fix TT-551 all users are returned from AD #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Hot fix TT-551 all users are returned from AD #372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab57f4
Revert changes in user
cxcarvaj Mar 9, 2022
ea0ba57
TT-551 hot fix
cxcarvaj Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert changes in user
  • Loading branch information
@cxcarvaj
cxcarvaj committed Mar 9, 2022
commit fab57f42320e2d23f0d52ccd140201761b5d33e5
2 changes: 1 addition & 1 deletion tests/utils/azure_users_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,4 +264,4 @@ def test_users_functions_should_returns_all_users(

users = AzureConnection().users()

assert len(users) == 2
assert len(users) == 0
8 changes: 3 additions & 5 deletions utils/azure_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,9 @@ def users(self) -> List[AzureUser]:
)[1]
endpoint = endpoint + skip_token_attribute + request_token

for user in users:
user_emails = user['otherMails']
email_domain = user_emails[0].split('@')[1]
if(len(user_emails) != 0 and email_domain == 'ioet.com'):
valid_users.append(user)
for i in range(len(users)):
if users[i]['mail'] is None:
valid_users.append(users[i])

return [self.to_azure_user(user) for user in valid_users]

Expand Down