Skip to content

fix: Show all users from ioet #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

fix: Show all users from ioet #368

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
187435d
fix: Show all users from ioet
Jobzi Mar 4, 2022
daa0e3b
refactor: change variable name
Jobzi Mar 4, 2022
577ebcc
refactor: revert changes
Jobzi Mar 4, 2022
bed2cc1
Fix tests and show all ioet users
cxcarvaj Mar 8, 2022
8b8ff43
Fix: error dependancies
cxcarvaj Mar 8, 2022
92f2bc7
Update env variables into the workflow
cxcarvaj Mar 8, 2022
2ad276e
Revert env variables
cxcarvaj Mar 8, 2022
29b497a
Revert env variables
cxcarvaj Mar 8, 2022
7cae56e
Refactor: pytests verbose
cxcarvaj Mar 8, 2022
b3e756f
Refactor: test failing in PR workflow
cxcarvaj Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: revert changes
  • Loading branch information
@Jobzi
Jobzi authored Mar 4, 2022
commit 577ebcc2486122f9ad1fd93532650dc40aa1e3f4
7 changes: 3 additions & 4 deletions utils/azure_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,9 @@ def users(self) -> List[AzureUser]:
)[1]
endpoint = endpoint + skip_token_attribute + request_token

for user in users:
user_emails = user['otherMails']
if(len(user_emails) != 0 and user_emails[0].split('@')[1] == 'ioet.com'):
valid_users.append(user)
for i in range(len(users)):
if users[i]['mail'] is None:
valid_users.append(users[i])

return [self.to_azure_user(user) for user in valid_users]

Expand Down