feat: TT-425 add time entries summary for a given range of dates#365
Closed
feat: TT-425 add time entries summary for a given range of dates#365
Conversation
mandres2015
reviewed
Dec 2, 2021
V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries_summary.py
Outdated
Show resolved
Hide resolved
V2/time_tracker/time_entries/_domain/_use_cases/_get_time_entries_summary_use_case.py
Show resolved
Hide resolved
V2/time_tracker/time_entries/_infrastructure/_data_persistence/_time_entries_sql_dao.py
Outdated
Show resolved
Hide resolved
V2/time_tracker/time_entries/_infrastructure/_data_persistence/_time_entries_sql_dao.py
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
mandres2015
reviewed
Dec 3, 2021
|
|
||
| response_params = { | ||
| "body": ResponseEnums.NOT_FOUND.value, | ||
| "status_code": HTTPStatus.NOT_FOUND, |
Collaborator
There was a problem hiding this comment.
This is not corrected yet
V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries_summary.py
Show resolved
Hide resolved
V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries_summary.py
Show resolved
Hide resolved
ararcos
reviewed
Dec 3, 2021
| def test__time_entry_summary_azure_endpoint__returns_invalid_date_format_with_invalid_date_format( | ||
| test_db, insert_activity, activity_factory | ||
| ): | ||
| insert_activity(activity_factory(), test_db) |
Collaborator
There was a problem hiding this comment.
what is the purpose of creating an activity if it is not used
ararcos
reviewed
Dec 3, 2021
| return func.HttpResponse(**response_params) | ||
|
|
||
|
|
||
| def _validate_time_format(time: str) -> bool: |
Collaborator
There was a problem hiding this comment.
perhaps this functionality can be implemented globally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this branch we created a new endpoint to retrieve a time entries summary that are located between two given dates.
get_time_entries_summary: [GET] http://localhost:7071/api/time-entries/summary/
Query params required: owner_id, start_date, end_date