Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-418 code smell resolved
  • Loading branch information
mandres2015 committed Nov 26, 2021
commit 4e51c432676e1566454b476a6ca6df03370f6f31
2 changes: 1 addition & 1 deletion V2/tests/integration/daos/customers_dao_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def test__update_customer_dao__returns_an_updated_customer_dto__when_updates_cor
assert updated_customer.__dict__ == inserted_customer


def test__update_customer_dao__returns_None__when_an_incorrect_id_is_passed(
def test__update_customer_dao__returns_none__when_an_incorrect_id_is_passed(
test_db, customer_factory, create_fake_dao, insert_customer
):
dao = create_fake_dao(test_db)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ def create_customer(req: func.HttpRequest) -> func.HttpResponse:
)


def _validate_customer(customer_data: dict) -> bool:
def _validate_customer(customer_data: dict) -> typing.List[str]:
return [field.name for field in dataclasses.fields(_domain.Customer)
if (field.name not in customer_data) and (field.type != typing.Optional[field.type])]