Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: TT-417 add missing tests and resolve comments
  • Loading branch information
ararcos authored and Jobzi committed Nov 25, 2021
commit 25f78608fd1784fde997456a569078cf461545e3
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

from ... import _domain
from ... import _infrastructure
from time_tracker._infrastructure import DB
from time_tracker._infrastructure import DB as database
from time_tracker.utils.enums import ResponseEnums as enums


def delete_project(req: func.HttpRequest) -> func.HttpResponse:
project_dao = _infrastructure.ProjectsSQLDao(DB())
project_dao = _infrastructure.ProjectsSQLDao(database())
project_service = _domain.ProjectService(project_dao)
use_case = _domain._use_cases.DeleteProjectUseCase(project_service)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@

from ... import _domain
from ... import _infrastructure
from time_tracker._infrastructure import DB
from time_tracker._infrastructure import DB as database
from time_tracker.utils.enums import ResponseEnums as enums


def get_projects(req: func.HttpRequest) -> func.HttpResponse:
database = DB()
project_dao = _infrastructure.ProjectsSQLDao(database)
project_dao = _infrastructure.ProjectsSQLDao(database())
project_service = _domain.ProjectService(project_dao)

project_id = req.route_params.get("id")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@

from ... import _domain
from ... import _infrastructure
from time_tracker._infrastructure import DB
from time_tracker._infrastructure import DB as database
from time_tracker.utils.enums import ResponseEnums as enums


def update_project(req: func.HttpRequest) -> func.HttpResponse:
database = DB()
project_dao = _infrastructure.ProjectsSQLDao(database)
project_dao = _infrastructure.ProjectsSQLDao(database())
project_service = _domain.ProjectService(project_dao)
use_case = _domain._use_cases.UpdateProjectUseCase(project_service)

Expand Down Expand Up @@ -41,6 +40,12 @@ def update_project(req: func.HttpRequest) -> func.HttpResponse:
status_code=enums.STATUS_BAD_REQUEST.value,
mimetype=enums.MIME_TYPE.value,
)
except Exception as error:
return func.HttpResponse(
body=str(error).encode(),
status_code=enums.STATUS_BAD_REQUEST.value,
mimetype=enums.MIME_TYPE.value,
)


def _validate_project(project_data: dict) -> bool:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,12 @@ def delete(self, id: int) -> domain.Project:
return self.get_by_id(id)

def update(self, id: int, project_data: dict) -> domain.Project:
query = self.project.update().where(self.project.c.id == id).values(project_data)
self.db.get_session().execute(query)
return self.get_by_id(id)
try:
query = self.project.update().where(self.project.c.id == id).values(project_data)
self.db.get_session().execute(query)
return self.get_by_id(id)
except sq.exc.SQLAlchemyError as error:
raise Exception(error.orig)

def __create_project_dto(self, project: dict) -> domain.Project:
project = {key: project.get(key) for key in self.project_key}
Expand Down