Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-402 Resolve comments
  • Loading branch information
Jobzi committed Nov 24, 2021
commit 406e7f4b8cb0ea9621f5825ef8e770b1d5e3b6b4
22 changes: 19 additions & 3 deletions V2/tests/api/azure/time_entry_azure_endpoints_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def test__delete_time_entries_azure_endpoint__returns_a_status_code_400__when_ti
assert response.get_body() == b'Invalid Format ID'


def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_activity_to_update(
def test__update_time_entry_azure_endpoint__returns_an_time_entry__when_found_an_time_entry_to_update(
test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
):
inserted_activity = insert_activity(activity_factory(), test_db)
Expand All @@ -103,7 +103,7 @@ def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_act
assert activitiy_json_data == json.dumps(inserted_time_entries)


def test__update_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_id():
def test__update_time_entries_azure_endpoint__returns_a_status_code_404__when_time_entry_recive_invalid_id():
time_entry_body = {"description": Faker().sentence()}

req = func.HttpRequest(
Expand All @@ -115,5 +115,21 @@ def test__update_time_entries_azure_endpoint__returns_a_status_code_400__when_ti

response = azure_time_entries._update_time_entry.update_time_entry(req)

assert response.status_code == 404
assert response.get_body() == b'Invalid Format ID'


def test__update_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_body():

time_entry_body = Faker().pydict(5, True, str)
req = func.HttpRequest(
method="PUT",
body=json.dumps(time_entry_body).encode("utf-8"),
url=TIME_ENTRY_URL,
route_params={"id": Faker().pyint()},
)

response = azure_time_entries._update_time_entry.update_time_entry(req)

assert response.status_code == 400
assert response.get_body() == b'Invalid ID'
assert response.get_body() == b'Incorrect time entry body'
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def update_time_entry(req: func.HttpRequest) -> func.HttpResponse:
response = _update(int(time_entry_id), time_entry_data)
status_code = 200
except ValueError:
response = b'Invalid ID'
status_code = 400
response = b'Invalid Format ID'
status_code = 404
else:
response = b'Incorrect time entry body'
status_code = 400
Expand Down
2 changes: 1 addition & 1 deletion V2/time_tracker/time_entries/_domain/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
from ._use_cases import (
CreateTimeEntryUseCase,
DeleteTimeEntryUseCase,
UpdateTimeEntryUseCase
UpdateTimeEntryUseCase,
)