Dockerize app #34
Merged
Dockerize app #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliuX
reviewed
Mar 19, 2020
Dockerfile
Outdated
|
|
||
| EXPOSE 5000 | ||
|
|
||
| CMD ["gunicorn", "-b 0.0.0.0:5000", "run:app"] No newline at end of file |
EliuX
reviewed
Mar 19, 2020
README.md
Outdated
| docker run -p 5000:5000 time_tracker_api:local | ||
| ``` | ||
|
|
||
| 3. Visit `0.0.0.0:5000` |
There was a problem hiding this comment.
Actually he needs to visit localhost or 127.0.0.1. The IP 0.0.0.0 makes sense inside docker but outside you will get this error
enriquezrene
approved these changes
Mar 20, 2020
fabidick22
reviewed
Mar 20, 2020
There was a problem hiding this comment.
Why use the ubuntu:18.04 image, I think this is a very thought image to package the application (the size of this is around 500MB), I think you can use a lighter version for this, something like Alpine Linux.
You might be interested in checking this out: https://hub.docker.com/r/tiangolo/meinheld-gunicorn-flask/tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dockerfile and instructions to run app dockerized.