Skip to content

fix: TT-393 userid convert to list #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2021
Merged

fix: TT-393 userid convert to list #339

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
003376d
feat: TT-365 Method POST activity and create function serverless
scastillo-jp Oct 28, 2021
bcea65a
solve merge conflicts
dsgarcia8 Nov 3, 2021
1590b14
Merge branch 'master' of github.com:ioet/time-tracker-backend
dsgarcia8 Nov 5, 2021
ee50bfd
fix: TT-393 change user id variable to list
dsgarcia8 Nov 8, 2021
4b071a1
TT-393 added list to userid
mandres2015 Nov 9, 2021
9c0e8e0
TT-393 added list to userid
mandres2015 Nov 10, 2021
2c04731
TT-393 resolve comment
mandres2015 Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TT-393 added list to userid
  • Loading branch information
@mandres2015
mandres2015 committed Nov 10, 2021
commit 9c0e8e03abbde53fd5791c159043864b8b092a32
5 changes: 3 additions & 2 deletions utils/azure_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class MSConfig:
SECRET = os.environ.get('MS_SECRET')
SCOPE = os.environ.get('MS_SCOPE')
ENDPOINT = os.environ.get('MS_ENDPOINT')
USERID = os.environ.get('USERID').split(" ")
USERID = os.environ.get('USERID')


class BearerAuth(requests.auth.AuthBase):
Expand Down Expand Up @@ -263,7 +263,8 @@ def get_groups_and_users(self):
[member['objectId'] for member in item['members']],
)
result = list(map(parse_item, response.json()['value']))
result[0][1].extend(self.config.USERID)
list_of_userid = self.config.USERID.split(" ")
Copy link
Collaborator

@scastillo-jp scastillo-jp Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change ** list_of_userid ** to ** users_id **
  • I recommend using , as the split symbol.

Copy link
Contributor

@dsgarcia8 dsgarcia8 Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve comment

result[0][1].extend(list_of_userid)

return result

Expand Down