TT-357 Create V2 Activities Azure DAO #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V2/time_entries/_infrastructure/_data_persistence/_activities_sql_dao.py
Outdated
Show resolved
Hide resolved
V2/time_entries/_infrastructure/_data_persistence/_activities_sql_dao.py
Outdated
Show resolved
Hide resolved
ararcos
requested review from
eguezgustavo,
faustocv,
Jobzi,
josepato87 and
scastillo-jp
ararcos
force-pushed
the
TT-357-Create-V2-Activities-Azure-DAO
branch
from
c353fb4 to
2eed400
Compare
|
¿Podemos usar "Type Hints" para indicar el retorno de los métodos? |
eguezgustavo
reviewed
Nov 5, 2021
V2/time_entries/_infrastructure/_data_persistence/_activities_sql_dao.py
Outdated
Show resolved
Hide resolved
ararcos
force-pushed
the
TT-357-Create-V2-Activities-Azure-DAO
branch
from
0b030d6 to
f17ea3c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
eguezgustavo
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request we worked on the TT-357 Create V2 Activities Azure DAO ticket, in this functionality we added the connection to the local postgress database hosted in a docker container.
To pull up the local docker container we should do it with the following command