Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9711ceb
feat: TT-356 Read activities with an azure endpoint
Oct 11, 2021
193261f
refactor: TT-356 Solving code smells from Sonarcloud
Oct 11, 2021
7a8df35
refactor: TT-356 Solving merge conflicts
Oct 13, 2021
11831bd
refactor: TT-356 change directory from files in source to azure_time_…
Oct 13, 2021
6967d42
test: TT-356 Adding azure endpoint api test
Oct 13, 2021
d9ab6a4
feat: TT-358 Use serverless to create Azure endpoint
Oct 14, 2021
c878eb3
refactor: TT-358 Changing time tracker backend app skeleton
Oct 15, 2021
1c28197
refactor: TT-358 Change name to the domain partitioning
Oct 18, 2021
2eb86cd
refactor: TT-358 Change route of activities data json file for azure …
Oct 18, 2021
8a073c3
refactor: TT-358 Change folder structure according to new app skeleton
Oct 19, 2021
f176589
feat: TT-358 Add Makefile to install time tracker backend
Oct 20, 2021
7325a84
refactor: TT-367 merge branch TT-358
JosueOb Oct 21, 2021
936c71e
refactor: TT-358 Change api test to use create temp activities fixture
Oct 22, 2021
b823e87
refactor: TT-367 solving merge conflicts
JosueOb Oct 25, 2021
f13bc69
feat: TT-367 creation of the functionality to change the status of an…
JosueOb Oct 25, 2021
687387f
test: TT-367 unit test for activity service
JosueOb Oct 26, 2021
54ba9cd
test: TT-367 unit test for delete activity use case
JosueOb Oct 26, 2021
2954640
test: TT-367 integration test for activities json dao
JosueOb Oct 26, 2021
d3629b9
test: TT-367 api test for endpoint to delete an activity
JosueOb Oct 26, 2021
e2284c9
refactor: TT-367 solving merge conflicts
JosueOb Oct 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: TT-367 creation of the functionality to change the status of an…
… activity
  • Loading branch information
JosueOb committed Oct 25, 2021
commit f13bc69b381300bfa117b2f5f29ef05bbbd34b90
10 changes: 10 additions & 0 deletions V2/serverless.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,13 @@ functions:
- GET
route: activities/{id:?}
authLevel: anonymous

delete_activity:
handler: time_entries/interface.delete_activity
events:
- http: true
x-azure-settings:
methods:
- DELETE
route: activities/{id}
authLevel: anonymous
1 change: 1 addition & 0 deletions V2/time_entries/_application/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
from ._activities import get_activities
from ._activities import delete_activity
1 change: 1 addition & 0 deletions V2/time_entries/_application/_activities/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
from ._get_activities import get_activities
from ._delete_activity import delete_activity
36 changes: 36 additions & 0 deletions V2/time_entries/_application/_activities/_delete_activity.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
from time_entries._infrastructure import ActivitiesJsonDao
from time_entries._domain import ActivityService, _use_cases

import azure.functions as func
import json
import logging

JSON_PATH = (
'time_entries/_infrastructure/_data_persistence/activities_data.json'
)


def delete_activity(req: func.HttpRequest) -> func.HttpResponse:
logging.info(
'Python HTTP trigger function processed a request to delete an activity.'
)
activity_id = req.route_params.get('id')
response = _delete(activity_id)
status_code = 200 if response == b'Not found' else 404

return func.HttpResponse(
body=response, status_code=status_code, mimetype="application/json"
)


def _delete(activity_id: str) -> str:
activity_use_case = _use_cases.DeleteActivityUseCase(
_create_activity_service(JSON_PATH)
)
activity = activity_use_case.delete_activity(activity_id)
return json.dumps(activity.__dict__) if activity else b'Not found'


def _create_activity_service(path: str):
activity_json = ActivitiesJsonDao(path)
return ActivityService(activity_json)
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@ def get_by_id(self, id: str) -> Activity:
@abc.abstractmethod
def get_all(self) -> typing.List[Activity]:
pass

@abc.abstractmethod
def delete(self, id: str) -> Activity:
pass
3 changes: 3 additions & 0 deletions V2/time_entries/_domain/_services/_activity.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ def get_by_id(self, activity_id: str) -> Activity:

def get_all(self) -> typing.List[Activity]:
return self.activities_dao.get_all()

def delete(self, activity_id: str) -> Activity:
return self.activities_dao.delete(activity_id)
1 change: 1 addition & 0 deletions V2/time_entries/_domain/_use_cases/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
from ._get_activities_use_case import GetActivitiesUseCase
from ._get_activity_by_id_use_case import GetActivityUseCase
from ._delete_activity_use_case import DeleteActivityUseCase
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from time_entries._domain import ActivityService, Activity


class DeleteActivityUseCase:
def __init__(self, activity_service: ActivityService):
self.activity_service = activity_service

def delete_activity(self, id: str) -> Activity:
return self.activity_service.delete(id)
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,32 @@ def get_all(self) -> typing.List[Activity]:
for activity in self.__get_activities_from_file()
]

def delete(self, activity_id: str) -> Activity:
activity = self.get_by_id(activity_id)
if activity:
activity_deleted = {**activity.__dict__, 'status': 'inactive'}
activities_updated = list(
map(
lambda activity: activity
if activity.get('id') != activity_id
else activity_deleted,
self.__get_activities_from_file(),
)
)

try:
file = open(self.json_data_file_path, 'w')
json.dump(activities_updated, file)
file.close()

return self.__create_activity_dto(activity_deleted)

except FileNotFoundError:
return None

else:
return None

def __get_activities_from_file(self) -> typing.List[dict]:
try:
file = open(self.json_data_file_path)
Expand Down
1 change: 1 addition & 0 deletions V2/time_entries/interface.py
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
from ._application import get_activities
from ._application import delete_activity