Skip to content

TT-365 / TT-369 POST V2 Activity #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2021
Merged

TT-365 / TT-369 POST V2 Activity #329

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ed1bf0
feat: TT-365 Method POST activity and create function serverless
scastillo-jp Oct 28, 2021
b7f9dd1
fix: TT-365 resolve comments
scastillo-jp Oct 29, 2021
e4496a4
fix: TT-365 format code
scastillo-jp Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: TT-365 format code
  • Loading branch information
@scastillo-jp
scastillo-jp committed Nov 3, 2021
commit e4496a4ef8c811a5d1448262e4e1ddca3db864ee
11 changes: 7 additions & 4 deletions V2/time_entries/_application/_activities/_create_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,18 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:
activity_dao = _infrastructure.ActivitiesJsonDao(_JSON_PATH)
activity_service = _domain.ActivityService(activity_dao)
use_case = _domain._use_cases.CreateActivityUseCase(activity_service)
logging.info(
'Python HTTP trigger function processed a request to create an activity.'
)


activity_data = req.get_json()


validation_errors = _validate_activity(activity_data)
if validation_errors:
return func.HttpResponse(
body=validation_errors, status_code=400, mimetype="application/json"
)


activity_to_create = _domain.Activity(
id= None,
name=activity_data['name'],
Expand All @@ -35,6 +38,7 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:
tenant_id=activity_data['tenant_id']
)


created_activity = use_case.create_activity(activity_to_create.__dict__)
if not create_activity:
return func.HttpResponse(
Expand All @@ -51,7 +55,6 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:

def _validate_activity(activity_data: dict) -> typing.List[str]:
activity_fields = [field.name for field in dataclasses.fields(_domain.Activity)]

missing_keys = [field for field in activity_fields if field not in activity_data]
return [
f'The {missing_key} key is missing in the input data'
Expand Down