TT-352 create v2 read activites flask endpoint #324
Conversation
…read-activites-flask-endpoint
JosueOb
requested review from
EdansRocks,
Jobzi,
bytesantiago,
dsgarcia8,
edgardavid2015 and
eguezgustavo
JosueOb
changed the title
JosueOb
changed the title
| import json | ||
| import typing | ||
|
|
||
|
|
There was a problem hiding this comment.
Siempre deben quedar dos líneas entre los imports y las clases o funciones de acuerdo a PEP 8. Creo que estaba bien
| if test_config is not None: | ||
| app.config.from_mapping(test_config) | ||
|
|
||
| ns_activities = Namespace('activities', description='Endpoint for activities') |
There was a problem hiding this comment.
con el prefijo ns_ te refieres a que es un namespace? capaz es mejor cambiar el nombre a activities_namespace
|
|
||
| class Activities(Resource): | ||
| def get(self): | ||
| activities_dto = use_cases.get_list_activities() |
| class Activity(Resource): | ||
| def get(self, activity_id: str): | ||
| try: | ||
| activities_dto = use_cases.get_activity_by_id(activity_id) |
…itivies from JSON file
| yield client | ||
|
|
||
|
|
||
| def test__activities_class__uses_the_get_activities_use_case__to_retrieve_activities(client: FlaskClient, |
There was a problem hiding this comment.
Me gusta un montón el typing en el test
|
|
||
| def test__activities_class__uses_the_get_activities_use_case__to_retrieve_activities(client: FlaskClient, | ||
| mocker: MockFixture): | ||
| use_cases.get_list_activities = mocker.Mock(return_value=[]) |
There was a problem hiding this comment.
esto se hace con mocker.patch en lugar de reemplazar el valor real de get_list_activities
| yield client | ||
|
|
||
|
|
||
| def test__activities_class__uses_the_get_activities_use_case__to_retrieve_activities(client: FlaskClient, |
There was a problem hiding this comment.
El nombre de esta prueba dice: test__activities_class. Pero no estamos probando el activities class, estamos probando el endpoint de /activities. Entonces, este test no es un test unitario es un test de API y habría que ponerle en la correspondiente carpeta
| assert [] == json_data | ||
|
|
||
|
|
||
| def test__activity_class__returns_an_activity__when_activity_matches_its_id(client: FlaskClient, mocker: MockFixture): |
| assert fake_activity == json.loads(response.data) | ||
|
|
||
|
|
||
| def test__activity_class__returns_an_activity__when_no_activity_matches_its_id(client: FlaskClient, |
| fake = Faker() | ||
|
|
||
|
|
||
| def test__get_list_activities_function__uses_the_activities_service__to_retrieve_activities(mocker: MockFixture): |
|
|
||
| class Activities(Resource): | ||
| def get(self): | ||
| activity_json = ActivitiesJsonDao(JSON_PATH) |
There was a problem hiding this comment.
Este código está duplicado con la línea 21
|
Kudos, SonarCloud Quality Gate passed!
|
Description
In this pull request, use cases and endpoints were created using flask to access activity data from a JSON file, according to the new backend architecture for the Time Tracker project.
The following image shows the new backend architecture.