refactor: TT-308 Use enums insted defined variables #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalarcon98
requested review from
JosueOb,
bytesantiago,
edgardavid2015,
ridouku and
scastillo-jp
ridouku
approved these changes
Aug 6, 2021
edgardavid2015
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Everything in the backend works fine, great job @jcalarcon98.
scastillo-jp
approved these changes
Aug 10, 2021
jcalarcon98
force-pushed
the
TT-308-use-enums-insted-defined-variables
branch
from
0760b76 to
fef705c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In many parts of the backend code, variables have been statically defined as 'active'/'inactive', this makes it difficult to maintain the code in the long term, so the use of Enums should be prioritized with this PR this objective was achieved