refactor: TT-245 refactor on find all function in cosmos db repository class #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalarcon98
requested review from
JosueOb,
PieritoAlva95,
bytesantiago,
edgardavid2015,
jase156,
kevinjlope,
ridouku and
scastillo-jp
ridouku
approved these changes
Jul 30, 2021
edgardavid2015
approved these changes
Aug 3, 2021
Contributor
edgardavid2015
left a comment
edgardavid2015
left a comment
There was a problem hiding this comment.
Everything is working fine. Well done Jean Carlos.
scastillo-jp
approved these changes
Aug 5, 2021
Collaborator
|
Good job @jcalarcon98 |
jcalarcon98
force-pushed
the
TT-245-refactor-on-find-all-function-in-cosmos-db-repository
branch
from
28c5b45 to
ef4b438
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jcalarcon98
deleted the
TT-245-refactor-on-find-all-function-in-cosmos-db-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function find_all within the CosmosDBRepository contains an earlier implementation, without using the project's query builder
Solution
With this PR this implementation is updated, using the query builder, in addition to eliminating implementations that are no longer necessary, since they are implemented at the Query builder level, also some refactoring is done in most of the modified files.