fix: TT-288 Fix and improve tests on find_interception_with_date_range function #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalarcon98
requested review from
PieritoAlva95,
bytesantiago,
jase156,
kevinjlope and
scastillo-jp
PieritoAlva95
approved these changes
Jul 16, 2021
Contributor
PieritoAlva95
left a comment
PieritoAlva95
left a comment
There was a problem hiding this comment.
Very good work Jean Carlos. 👍🏼 💯 🥇
kevinjlope
approved these changes
Jul 16, 2021
jcalarcon98
force-pushed
the
TT-288-fix-tests-on-find-interception-with-date-range-function
branch
from
05288d6 to
c8235ac
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jcalarcon98
deleted the
TT-288-fix-tests-on-find-interception-with-date-range-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there are tests that validate the operation of the find_interception_with_date_range function, however, these tests are creating entries in the production database, it is also important to clarify that each of the tests deletes the entry created.
Solution
To prevent these entries from being created, it was decided to mock the return value when querying entries that clash with the entry to be created