fix: TT-287 Fix users email doesn't show in reports page #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: TT-287 Add test for AzureConnection.users function
jcalarcon98
requested review from
scastillo-jp,
PieritoAlva95,
jase156,
kevinjlope and
lenshinoda
|
Kudos, SonarCloud Quality Gate passed!
|
jase156
reviewed
Jul 8, 2021
PieritoAlva95
approved these changes
Jul 9, 2021
scastillo-jp
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description:
Currently the Reports Page does not load the emails of some users, this is because the current implementation does not take into account that the Azure endpoint only returns the first 100 users.
Solution:
In the user request, if there are more users, the Azure api returns an additional field named
o.datanextLink, as long as the API returns this field he following number of remaining users is consumed.