fix: TT-270 Handle exceptions in create update entries #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
jcalarcon98
requested review from
PieritoAlva95,
jase156,
kevinjlope,
lenshinoda and
scastillo-jp
scastillo-jp
approved these changes
Jun 22, 2021
jcalarcon98
deleted the
TT-270-handle-exceptions-in-create-update-entries
branch
scastillo-jp
added a commit
that referenced
this pull request
Jun 24, 2021
)" This reverts commit 3cddc6b.
scastillo-jp
restored the
TT-270-handle-exceptions-in-create-update-entries
branch
scastillo-jp
added a commit
that referenced
this pull request
Jun 24, 2021
)" This reverts commit 3cddc6b.
jcalarcon98
added a commit
that referenced
this pull request
Jul 7, 2021
jcalarcon98
added a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if we want to create a new entry and we don't pass
activity_idfield, the activity will be create without a problem.For example:
This behavior can cause problems when we try to get all the Entries and in the UI part, it will not render reports Page, and time Entries page.
With this PR, it is checked that an activity and a project are provided, and also that the projects or activities entered exist. for example:
Entry without
activity_idfield:**Entry with fake
activity_idfield: **