Skip to content

fix: TT-261 handle response Not found #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2021
Merged

fix: TT-261 handle response Not found #299

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a3c845
fix: TT-261 handle response Not found and added unit testing of metho…
kevinjlope Jun 9, 2021
8c89c81
fix: TT-261 refactor code based on PR reviews
kevinjlope Jun 11, 2021
a322986
fix: TT-261 refactor code based on PR reviews
kevinjlope Jun 14, 2021
af2ff3c
fix: TT-261 added a second test about the methond add_complementary_info
kevinjlope Jun 15, 2021
9a90ec5
fix: TT-261 corection about of the code smell
kevinjlope Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-261 refactor code based on PR reviews
  • Loading branch information
@kevinjlope
kevinjlope committed Jun 14, 2021
commit a3229869c18c9392c619cbde7cd73f550d3c8dbd
69 changes: 30 additions & 39 deletions tests/time_tracker_api/time_entries/time_entries_repository_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,42 +13,33 @@
ActivityCosmosDBModel,
)

time_entry_data = {
'id': 'id',
'start_date': '2021-03-22T10:00:00.000Z',
'end_date': "2021-03-22T11:00:00.000Z",
'description': 'do some testing',
'tenant_id': 'tenant_id',
'project_id': 'project_id1',
'activity_id': 'activity_id1',
'technologies': ['python', 'pytest'],
'owner_id': 'id',
}

def create_time_entry_data():
time_entry_data = {
'id': 'id',
'start_date': '2021-03-22T10:00:00.000Z',
'end_date': "2021-03-22T11:00:00.000Z",
'description': 'do some testing',
'tenant_id': 'tenant_id',
'project_id': 'project_id1',
'activity_id': 'activity_id1',
'technologies': ['python', 'pytest'],
'owner_id': 'id',
}
return time_entry_data
project_data = {
'customer_id': 'dsakldh12ASD',
'id': 'project_id1',
'name': 'project_name',
'description': 'do some testing',
'project_type_id': "id2",
'tenant_id': 'tenantid1',
}


def create_project_data():
project_data = {
'customer_id': 'dsakldh12ASD',
'id': 'project_id1',
'name': 'project_name',
'description': 'do some testing',
'project_type_id': "id2",
'tenant_id': 'tenantid1',
}
return project_data


def create_activity_data():
activity_data = {
'id': 'activity_id1',
'name': 'activity',
'description': 'testing',
"tenant_id": 'nomatter',
}
return activity_data
activity_data = {
'id': 'activity_id1',
'name': 'activity',
'description': 'testing',
"tenant_id": 'nomatter',
}


def test_add_complementary_info(
Expand All @@ -63,15 +54,15 @@ def test_add_complementary_info(
)
users_mock = mocker.patch.object(AzureConnection, 'users')

expected_project = ProjectCosmosDBModel(create_project_data())
expected_activity = ActivityCosmosDBModel(create_activity_data())
expected_time_entry_in = TimeEntryCosmosDBModel(create_time_entry_data())
expected_users = AzureUser('email1', [], 'id', 'name', ['admin'])
expected_project = ProjectCosmosDBModel(project_data)
expected_activity = ActivityCosmosDBModel(activity_data)
expected_time_entry_in = TimeEntryCosmosDBModel(time_entry_data)
expected_user = AzureUser('email1', [], 'id', 'name', ['admin'])
setattr(expected_project, 'customer_name', 'customer_name')

projects_db_get_all_mock.return_value = [expected_project]
activities_db_get_all_mock.return_value = [expected_activity]
users_mock.return_value = [expected_users]
users_mock.return_value = [expected_user]

expected_time_entry_out = time_entry_repository.add_complementary_info(
[expected_time_entry_in], max_count=None, exist_conditions=True
Expand Down