Tt 220 remove custom sql conditions from find all #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

scastillo-jp merged 12 commits into master from TT-220-remove-custom-sql-conditions-from-find-all

May 26, 2021

Contributor

pfsolorzanos commented May 17, 2021

No description provided.

Pablo and others added 8 commits

May 17, 2021 12:39


          fix: TT-220 refactoring for projects

58de09b


          fix: TT-238 activities find_all refactoring

6399ba6


          fix: TT-220 Correction in get_all function for projects_model

7400b90


          fix: TT-220 Remove custom_sql_params from methods and replace for new…

9e9fd0c

… arguments and function calls


          fix: TT-220 apply refactoring on some code

c95fc27


          fix: TT-220 Bugs corrections

a77a420


          fix: TT-220 Removes order conditions from activities

d43d88b


          fix: TT-220 make adjustments in projects query for time-entries

37df429

pfsolorzanos requested a review from scastillo-jp

May 17, 2021 17:51

scastillo-jp requested a review from Angeluz-07

May 17, 2021 19:10


          fix: TT-220 adjustments according sonar suggestions

9eb0e96

pfsolorzanos force-pushed the TT-220-remove-custom-sql-conditions-from-find-all branch from 6b1e089 to 9eb0e96 Compare

May 19, 2021 13:52

Pablo added 2 commits

May 19, 2021 09:09


          fix: TT-220 adjustments according sonar suggestions in activities

d13c19d


          fix: TT-220 adjustments according sonar code analysis

8a2682a

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/activities/activities_model.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/data_access_layer/cosmos_db.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/data_access_layer/cosmos_db.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/data_access_layer/cosmos_db.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

tests/utils/query_builder_test.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_repository.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

utils/query_builder.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

utils/query_builder.py Outdated Show resolved Hide resolved

Angeluz-07 suggested changes

View reviewed changes

Contributor

Angeluz-07 left a comment

Goode Job. Some comments.


          fix: TT-220 adjustments according reviewers suggestions

ede5c4c

pfsolorzanos force-pushed the TT-220-remove-custom-sql-conditions-from-find-all branch from 10ffeb1 to ede5c4c Compare

May 20, 2021 19:45

sonarqubecloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

scastillo-jp approved these changes

View reviewed changes

scastillo-jp merged commit 91d6507 into master

scastillo-jp deleted the TT-220-remove-custom-sql-conditions-from-find-all branch

May 26, 2021 12:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet