Skip to content

Tt 237 update time entries #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2021
Merged

Tt 237 update time entries #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c635dcb
fix: TT-237 Fix test to Update Start time Entries
jase156 May 7, 2021
bbac4fb
Fix: TT-237 Fix update time entries
jase156 May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/time_tracker_api/time_entries/time_entries_namespace_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,12 @@ def test_update_time_entry_calls_partial_update_with_incoming_payload(
mocker: MockFixture,
valid_header: dict,
valid_id: str,
owner_id: str,
time_entries_dao,
):
valid_time_entry_input_to_update = valid_time_entry_input.copy()
valid_time_entry_input_to_update["owner_id"] = owner_id

time_entries_dao.repository.partial_update = Mock(return_value={})

time_entries_dao.repository.find = Mock(return_value={})
Expand All @@ -420,13 +424,13 @@ def test_update_time_entry_calls_partial_update_with_incoming_payload(
response = client.put(
f'/time-entries/{valid_id}',
headers=valid_header,
json=valid_time_entry_input,
json=valid_time_entry_input_to_update,
follow_redirects=True,
)

assert HTTPStatus.OK == response.status_code
time_entries_dao.repository.partial_update.assert_called_once_with(
valid_id, valid_time_entry_input, ANY
valid_id, valid_time_entry_input_to_update, ANY
)

time_entries_dao.repository.find.assert_called_once()
Expand Down Expand Up @@ -464,10 +468,14 @@ def test_update_time_entry_raise_not_found(
mocker: MockFixture,
valid_header: dict,
valid_id: str,
owner_id: str,
time_entries_dao,
):
from werkzeug.exceptions import NotFound

valid_time_entry_input_to_update = valid_time_entry_input.copy()
valid_time_entry_input_to_update["owner_id"] = owner_id

time_entries_dao.repository.partial_update = Mock(side_effect=NotFound)

time_entries_dao.repository.find = Mock(return_value={})
Expand All @@ -476,13 +484,13 @@ def test_update_time_entry_raise_not_found(
response = client.put(
f'/time-entries/{valid_id}',
headers=valid_header,
json=valid_time_entry_input,
json=valid_time_entry_input_to_update,
follow_redirects=True,
)

assert HTTPStatus.NOT_FOUND == response.status_code
time_entries_dao.repository.partial_update.assert_called_once_with(
valid_id, valid_time_entry_input, ANY
valid_id, valid_time_entry_input_to_update, ANY
)

time_entries_dao.repository.find.assert_called_once()
Expand Down
1 change: 1 addition & 0 deletions time_tracker_api/time_entries/time_entries_dao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ def create(self, data: dict):

def update(self, id, data: dict, description=None):
event_ctx = self.create_event_context("update", description)
data['owner_id'] = event_ctx.user_id
time_entry = self.repository.find(id, event_ctx)
self.check_whether_current_user_owns_item(time_entry)

Expand Down