Skip to content

refactor: TT-182 create method to get all projects with list of ids #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2021
Merged

refactor: TT-182 create method to get all projects with list of ids #271

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd17303
refactor: TT-182 create method to get all projects with list of ids
eduardisrael Mar 26, 2021
ed3b150
refactor: TT-182 create method to get all projects with list of ids
eduardisrael Mar 29, 2021
56b8867
refactor: TT-182 solve PR comments
eduardisrael Mar 30, 2021
e6eb905
Renamed ids_list, customers_ids to project_ids, customer_ids
eduardisrael Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Renamed ids_list, customers_ids to project_ids, customer_ids
  • Loading branch information
@eduardisrael
eduardisrael committed Mar 30, 2021
commit e6eb905f2dc0cb69f3a8e5edafc7605311d8b678
9 changes: 4 additions & 5 deletions time_tracker_api/projects/projects_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from time_tracker_api.customers.customers_model import CustomerCosmosDBModel
from utils.query_builder import CosmosDBQueryBuilder
from utils.extend_model import add_customer_name_to_projects
from utils.repository import create_sql_in_condition


class ProjectDao(CRUDDao):
Expand Down Expand Up @@ -69,14 +68,14 @@ def __init__(self):
def find_all_v2(
self,
event_context: EventContext,
ids_list: List[str],
customers_ids: List[str] = None,
project_ids: List[str],
customer_ids: List[str] = None,
visible_only=True,
mapper: Callable = None,
):
query_builder = (CosmosDBQueryBuilder()
.add_sql_in_condition("id",ids_list)
.add_sql_in_condition("customer_id",customers_ids)
.add_sql_in_condition("id",project_ids)
.add_sql_in_condition("customer_id",customer_ids)
.add_sql_visibility_condition(visible_only)
.build()
)
Expand Down