Skip to content

TT-181 create method to find all projects with list of customer ids #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

TT-181 create method to find all projects with list of customer ids #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c56d070
refactor: TT-180 add methods find_all_with_id_in_list and get_all_wit…
kellycastrof Mar 13, 2021
c9ae125
refactor: TT-180 changes in activity test
kellycastrof Mar 16, 2021
eaf5614
test: TT-180 add test validate list
Angeluz-07 Mar 16, 2021
0acdb5c
test: TT-180 add test convert list to tuple string
Angeluz-07 Mar 16, 2021
b0088b0
test: TT-180 add test create sql in condition
Angeluz-07 Mar 16, 2021
3f44227
test: TT-180 add test find_all, in progress
Angeluz-07 Mar 16, 2021
690af81
test: TT-180 add test find_all_with_id_in_list
Angeluz-07 Mar 16, 2021
98c883f
test: TT-180 remove unused imports, fix quotes
Angeluz-07 Mar 16, 2021
c94b511
refactor: TT-180 move convert_list_to_tuple_string and validate_list …
kellycastrof Mar 17, 2021
267ef7f
feat : TT-181 create method to find all projects with a list of custo…
eduardisrael Mar 17, 2021
79ace4b
feat: TT-181 change projects_model and projects_model_test functions …
eduardisrael Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: TT-181 change projects_model and projects_model_test functions … 
…name
  • Loading branch information
@eduardisrael
eduardisrael committed Mar 18, 2021
commit 79ace4b69fdec378299d9f10bfdec4908c606cda
8 changes: 4 additions & 4 deletions tests/time_tracker_api/projects/projects_model_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,22 @@ def test_create_sql_in_condition(
customer_ids_list,
expected_result,
):
result = project_repository.create_sql_in_condition(customer_ids_list)
result = project_repository.create_sql_customer_id_in_condition(customer_ids_list)
assert expected_result == result


@patch(
'time_tracker_api.projects.projects_model.ProjectCosmosDBRepository.create_sql_condition_for_visibility'
)
@patch(
'time_tracker_api.projects.projects_model.ProjectCosmosDBRepository.create_sql_in_condition'
'time_tracker_api.projects.projects_model.ProjectCosmosDBRepository.create_sql_customer_id_in_condition'
)
@patch(
'time_tracker_api.projects.projects_model.ProjectCosmosDBRepository.find_partition_key_value'
)
def test_find_all_with_customer_id_in_list(
find_partition_key_value_mock,
create_sql_in_condition_mock,
create_sql_customer_id_in_condition_mock,
create_sql_condition_for_visibility_mock,
event_context: EventContext,
project_repository: ProjectCosmosDBRepository,
Expand All @@ -56,7 +56,7 @@ def test_find_all_with_customer_id_in_list(
result = project_repository.find_all_with_customer_id_in_list(event_context, [])

create_sql_condition_for_visibility_mock.assert_called_once()
create_sql_in_condition_mock.assert_called_once()
create_sql_customer_id_in_condition_mock.assert_called_once()
find_partition_key_value_mock.assert_called_once()
query_items_mock.assert_called_once()

Expand Down
4 changes: 2 additions & 2 deletions time_tracker_api/projects/projects_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(self):
mapper=ProjectCosmosDBModel,
)

def create_sql_in_condition(self, customer_ids_list):
def create_sql_customer_id_in_condition(self, customer_ids_list):
id_values = convert_list_to_tuple_string(customer_ids_list)

return "c.customer_id IN {value_condition}".format(value_condition=id_values)
Expand All @@ -84,7 +84,7 @@ def find_all_with_customer_id_in_list(
WHERE {condition}
{visibility_condition}
""".format(
condition=self.create_sql_in_condition(customer_ids_list),
condition=self.create_sql_customer_id_in_condition(customer_ids_list),
visibility_condition=visibility,
)

Expand Down