feat: TT-169 add enpoints to add/remove users to/from groups #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRC-ioet
reviewed
Mar 5, 2021
| azure_connection = AzureConnection() | ||
| azure_connection.add_user_to_group('dummy_user_id', 'dummy_group') | ||
|
|
||
| get_group_id_by_group_name_mock.assert_called_once() |
There was a problem hiding this comment.
Do you think you can send an assert with the mock of a user in the test that is changing the group? It is optional because I see that if you are testing the methods.
PaulRC-ioet
reviewed
Mar 5, 2021
israteneda
approved these changes
Mar 5, 2021
scastillo-jp
approved these changes
Mar 5, 2021
PaulRC-ioet
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.