Skip to content

TT-156 add groups field in User model #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 1, 2021
Merged

TT-156 add groups field in User model #262

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ae854de
feat: TT-156 add group fields in model
Angeluz-07 Feb 24, 2021
59633d4
feat: TT-156 cache groups_and_users response for perfomance
Angeluz-07 Feb 25, 2021
956bfb5
test: TT-156 update tests
Angeluz-07 Feb 25, 2021
3d5fe42
test: TT-156 add get_grups_and_users test
Angeluz-07 Feb 26, 2021
5a11f04
fix: TT-156 remove debug statements
Angeluz-07 Feb 26, 2021
4c847ea
test: TT-156 add test for get_groups_by_user_id
Angeluz-07 Feb 26, 2021
8945be3
test: TT-156 parametrize test for get_groups_by_user_id
Angeluz-07 Feb 26, 2021
12ed65c
test: TT-156 get_groups_and_users_called_once_by_instance
Angeluz-07 Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: TT-156 parametrize test for get_groups_by_user_id
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Feb 26, 2021
commit 8945be38cab89c2b865526edd27c5d499c7c24db
19 changes: 14 additions & 5 deletions tests/utils/azure_users_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,23 @@ def test_get_groups_and_users(get_mock):
@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
@patch('utils.azure_users.AzureConnection.get_token', Mock())
@patch('utils.azure_users.AzureConnection.get_groups_and_users')
def test_get_groups_by_user_id(get_groups_and_users_mock):
@mark.parametrize(
'user_id,groups_expected_value',
[
('user-id1', ['test-group-1', 'test-group-2']),
('user-id2', ['test-group-1']),
('user-id3', ['test-group-2']),
('user-id4', []),
],
)
def test_get_groups_by_user_id(
get_groups_and_users_mock, user_id, groups_expected_value
):
get_groups_and_users_mock.return_value = [
('test-group-1', ['user-id1', 'user-id2']),
('test-group-2', ['user-id3', 'user-id1']),
]

azure_connection = AzureConnection()
user_id = 'user-id1'
expected_result = ['test-group-1', 'test-group-2']
groups = azure_connection.get_groups_by_user_id('user-id1')
assert groups == expected_result
groups = azure_connection.get_groups_by_user_id(user_id)
assert groups == groups_expected_value