Skip to content

TT - 112 Update role field #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 15, 2021
Merged

TT - 112 Update role field #251

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76f90cb
TT-112 feat: support role field as list
Angeluz-07 Jan 12, 2021
79ffbea
TT-112 feat: add feature toggle
Angeluz-07 Jan 12, 2021
4c1d47b
TT-112 feat: add unit test, update role contains expected props
Angeluz-07 Jan 13, 2021
4ddff30
TT-112 feat: add unit testfor users endpoint under feature toggle
Angeluz-07 Jan 13, 2021
e6e76f0
TT-112 feat: fix broken test
Angeluz-07 Jan 13, 2021
9698ff6
TT-112 fix: update role field value
Angeluz-07 Jan 15, 2021
c3ccb20
TT-112 feat: apply comments of PR
Angeluz-07 Jan 15, 2021
e472423
TT-112 feat: update var name of feature manager
Angeluz-07 Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TT-112 feat: update var name of feature manager
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Jan 15, 2021
commit e47242326df0a35d773d662595db6f6781dc202d
4 changes: 2 additions & 2 deletions time_tracker_api/users/users_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ class Users(Resource):
@ns.marshal_list_with(user_response_fields)
def get(self):
"""List all users"""
ftm = FeatureToggleManager('bk-user-role-field')
if ftm.is_toggle_enabled_for_user():
user_role_field_toggle = FeatureToggleManager('bk-user-role-field')
if user_role_field_toggle.is_toggle_enabled_for_user():
return AzureConnection().users_v2()
return AzureConnection().users()

Expand Down