Skip to content

TT-94 update role support #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 7, 2021
Merged

TT-94 update role support #249

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d1d209
TT-94 feat: add endpoints
Angeluz-07 Dec 24, 2020
2afb572
TT-94 feat: extract http-patch-headers into variable
Angeluz-07 Dec 24, 2020
ca5d135
TT-94 feat: add method to update role
Angeluz-07 Jan 5, 2021
275d6c5
TT-94 feat: extract role fields as global var
Angeluz-07 Jan 5, 2021
b97f87b
TT-94 feat: remove todos
Angeluz-07 Jan 5, 2021
7ce6e27
TT-94 feat: add tests for proper call to azureconnection method
Angeluz-07 Jan 5, 2021
549bef5
TT-94 feat: add assertion for valid ids
Angeluz-07 Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TT-94 feat: remove todos
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Jan 5, 2021
commit b97f87ba26c5ae7baacab8a1f2e89cd99228a978
2 changes: 0 additions & 2 deletions time_tracker_api/users/users_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def get(self):
return AzureConnection().users()


# TODO : DEPRECATE
@ns.route('/<string:id>/roles')
@ns.response(HTTPStatus.NOT_FOUND, 'User not found')
@ns.response(HTTPStatus.UNPROCESSABLE_ENTITY, 'The id has an invalid format')
Expand All @@ -77,7 +76,6 @@ def post(self, id):
return AzureConnection().update_user_role(id, ns.payload['role'])


# TODO : DEPRECATE
@ns.route('/<string:user_id>/roles/<string:role_id>')
@ns.response(HTTPStatus.NOT_FOUND, 'User not found')
@ns.response(HTTPStatus.UNPROCESSABLE_ENTITY, 'The id has an invalid format')
Expand Down
1 change: 0 additions & 1 deletion utils/azure_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ def users(self) -> List[AzureUser]:
assert 'value' in response.json()
return [self.to_azure_user(item) for item in response.json()['value']]

# TODO : DEPRECATE
def update_user_role(self, id, role):
endpoint = "{endpoint}/users/{user_id}?api-version=1.6".format(
endpoint=self.config.ENDPOINT, user_id=id
Expand Down