Skip to content

Refactor projects and time entries classes #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Refactor projects and time entries classes #225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33c29c
Splitting long classes into their own separate files
enriquezrene Nov 7, 2020
7c57f9f
Splitting long classes into their own separate files
enriquezrene Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Splitting long classes into their own separate files
  • Loading branch information
@enriquezrene
enriquezrene committed Nov 7, 2020
commit 7c57f9fc916bd49f058bf6e15972054ebb3ddece
1 change: 0 additions & 1 deletion time_tracker_api/time_entries/time_entries_dao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import abc
from azure.cosmos import PartitionKey
from flask_restplus import abort
from flask_restplus._http import HTTPStatus

Expand Down
23 changes: 0 additions & 23 deletions time_tracker_api/time_entries/time_entries_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import abc
from typing import List, Callable
from azure.cosmos import PartitionKey
from flask_restplus import abort
Expand All @@ -16,35 +15,13 @@
add_project_info_to_time_entries,
add_activity_name_to_time_entries,
create_in_condition,
create_custom_query_from_str,
add_user_email_to_time_entries,
)
from utils.time import (
current_datetime_str,
)
from utils.azure_users import AzureConnection

from time_tracker_api.projects import projects_model
from time_tracker_api.database import CRUDDao
from time_tracker_api.security import current_user_id


class TimeEntriesDao(CRUDDao):
@staticmethod
def current_user_id():
return current_user_id()

@abc.abstractmethod
def find_running(self):
pass

@abc.abstractmethod
def stop(self, id: str):
pass

@abc.abstractmethod
def restart(self, id: str):
pass


container_definition = {
Expand Down