Fixes #17 Add tests and coverage support #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabidick22
reviewed
Mar 13, 2020
tests/conftest.py
Outdated
Comment on lines
8
to
9
| app = create_app() | ||
| return app |
Contributor
There was a problem hiding this comment.
return create_app()
it's just a suggestion
Contributor
Author
There was a problem hiding this comment.
Makes sense, I just know that here in the middle I will have to do adjustments.
Contributor
Author
There was a problem hiding this comment.
But I applied your suggestion tho 👍
fabidick22
approved these changes
Mar 13, 2020
EliuX
force-pushed
the
feature/Add-test-and-cov#17
branch
from
707482d to
6318162
Compare
Angeluz-07
approved these changes
Mar 13, 2020
enriquezrene
suggested changes
Mar 13, 2020
enriquezrene
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pytest and coverage, in order to run tests and coverage reports respectively. It also adds a sample smoke_test.py to very that the tests are well installed by checking that the a reference to the app can be accessed. For better comprehension, more instructions were added to the README.md.