fix: allow limits overlap in time entries #217 #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ioet/time-tracker-ui#504
Close #217
This PR should fix the following problem:
You already have a time entry that starts at 11:00:00.
Then, you want to create a time entry that starts at 9:00:00 and ends at 11:00:00.
You can't because "There is already a time entry in that range"
You have to explicitly set your new time entry to (9:00:00 - 10:59:00)
I excluded these cases from the validation that is made when creating/updating time-entries.
Check
time_tracker_api/time_entries/time_entries_model.pylines 312, 313 for important changes. Andtests/time_tracker_api/time_entries/time_entries_model_test.pyline 216 for important unit test.