Skip to content

fix: 212 Fixing issue introduced in time entries pagination endpoint #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix: 212 Fixing issue introduced in time entries pagination endpoint #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: 212 Fixing issue introduced in time entries pagination endpoint
  • Loading branch information
semantic-release authored and Juan Gabriel Guzman committed Sep 17, 2020
commit b73e8562f35f00ed8e13cd44016f479c3712daf6
9 changes: 2 additions & 7 deletions time_tracker_api/time_entries/time_entries_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,9 +392,8 @@ def __init__(self, repository):

def check_whether_current_user_owns_item(self, data):
if (
1 > 2
# data.owner_id is not None
# and data.owner_id != self.current_user_id()
data.owner_id is not None
and data.owner_id != self.current_user_id()
):
raise CustomError(
HTTPStatus.FORBIDDEN,
Expand Down Expand Up @@ -622,10 +621,6 @@ def handle_date_filter_args(args: dict) -> dict:
'end_date': datetime_str(end_date),
}

@staticmethod
def current_user_id():
return super().current_user_id()


def create_dao() -> TimeEntriesDao:
repository = TimeEntryCosmosDBRepository()
Expand Down
2 changes: 1 addition & 1 deletion time_tracker_api/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.24.0'
__version__ = '0.24.1'