Skip to content

fix: #177 remove unnecesary queries from summaries endpoint #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix: #177 remove unnecesary queries from summaries endpoint #178

merged 2 commits into from
Jul 1, 2020

Conversation

@enriquezrene
Copy link
Contributor

@enriquezrene enriquezrene commented Jul 1, 2020

No description provided.

juanultimate
juanultimate reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@juanultimate juanultimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the test_summary_is_called_with_date_range_from_worked_time_module test. Here =>

time-tracker-backend/tests/time_tracker_api/time_entries/time_entries_namespace_test.py

Line 627 in 5f56976

time_entries_dao.repository, 'find_all', return_value=[]

@enriquezrene enriquezrene merged commit 4d0c8ce into master Jul 1, 2020
@enriquezrene enriquezrene deleted the 177-remove-unnecessary-queries branch July 1, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@juanultimate juanultimate juanultimate approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enriquezrene @juanultimate